New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy cache 4: A New Hope #29785
Merged
Merged
Lazy cache 4: A New Hope #29785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
added
the
tool
Affects the "flutter" command-line tool. See also t: labels.
label
Mar 22, 2019
gspencergoog
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this one either |
jonahwilliams
added a commit
that referenced
this pull request
Mar 26, 2019
This reverts commit d71f324.
Merged
jonahwilliams
added a commit
that referenced
this pull request
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to make artifact down-loading lazy. Classifies each
CachedArtifact
as being eitheruniversal
or supporting a specific platform. Refactors theEngineArtifact
class into a universal, android, or iOS category.Each command must identify which artifacts it requires statically. Currently all commands required universal, android, and iOS. The web sdk is now only downloaded when running
flutter build web
flutter precache
now accepts additional flags to force downloading of the artifacts, the defaults include android, ios, and universal.To improve downloading further, we need to identify which artifacts are required in the build commands
based on the target platform.
Related Issues
Work towards #6491
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?