Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh control in the gallery demo, update comments #30129

Merged
merged 21 commits into from
Apr 26, 2019
Merged

Fix refresh control in the gallery demo, update comments #30129

merged 21 commits into from
Apr 26, 2019

Conversation

LongCatIsLooong
Copy link
Contributor

Description

  • Fixed the bug where CupertinoRefreshControl doesn't work in the gallery demo on Android.
  • Updated documentation on CupertinoRefreshControl
  • Added comments to the gallery demo
  • Added concrete examples to ScrollPhysics

Related Issues

Fixes #21820

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 29, 2019
Merged
9 tasks
@goderbauer goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 30, 2019
@LongCatIsLooong LongCatIsLooong force-pushed the updateCupertinoSliverRefControlDoc branch from 0d1b366 to bd07e2c Compare April 1, 2019 22:09
@LongCatIsLooong LongCatIsLooong force-pushed the updateCupertinoSliverRefControlDoc branch from bd07e2c to dff5bf2 Compare April 1, 2019 22:13
@LongCatIsLooong LongCatIsLooong force-pushed the updateCupertinoSliverRefControlDoc branch 2 times, most recently from 9a46db2 to 477359e Compare April 1, 2019 22:41
@LongCatIsLooong LongCatIsLooong force-pushed the updateCupertinoSliverRefControlDoc branch from 477359e to 0348308 Compare April 1, 2019 22:43
@LongCatIsLooong
Copy link
Contributor Author

@xster the workaround seems to be working.

@xster
Copy link
Member

xster commented Apr 4, 2019

Is this ready for review?

@LongCatIsLooong
Copy link
Contributor Author

Is this ready for review?

yep

xster
xster reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I started reviewing but forgot to press submit

examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart Outdated Show resolved Hide resolved
examples/flutter_gallery/lib/demo/cupertino/cupertino_refresh_demo.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/refresh.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/refresh.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/refresh.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/refresh.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/refresh.dart Outdated Show resolved Hide resolved
xster
xster reviewed Apr 24, 2019
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/widgets/scroll_physics.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/scroll_physics.dart Outdated Show resolved Hide resolved
@xster
Copy link
Member

xster commented Apr 25, 2019

LGTM

@LongCatIsLooong LongCatIsLooong merged commit 7d19f97 into flutter:master Apr 26, 2019
@LongCatIsLooong LongCatIsLooong deleted the updateCupertinoSliverRefControlDoc branch April 26, 2019 03:49
This was referenced May 13, 2019
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster Awaiting requested review from xster

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CupertinoSliverRefreshControll not work on Android
4 participants
@LongCatIsLooong @xster @goderbauer @googlebot