refactor context to be implicit-downcast safe #31622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
May 1, 2019
| if (value == null && _parent != null) { | ||
| value = _parent.get<T>(); | ||
| } | ||
| return _unboxNull(value ?? _generateIfNecessary(T, _fallbacks)) as T; |
There was a problem hiding this comment.
You can avoid the as here by saying:
T result = _unboxNull(value ?? _generateIfNecessary(T, _fallbacks));
return result;(you can do the same above in AppContext get context)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate
Context.operator[]and replace it withContext.get<T>()which uses the generic to look up the token. This allows us to use theTto perform anascast to remove all context related implicit downcasts.Old method is marked as deprecated to make it easier to migrate g3 usages of tool context.
Replaces #31031
Related Issues
#13815