Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notification errors #31868

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 30, 2019

Description

This specifies the unhandled JSON RPC errors to ignore notification related errors.

Per the spec, the server is not to send anything back to the client on a notification. If, however, the client sends a notification for a method that isn't registered, the RPC server is now pumping that back to our handler. This adds logic to the handlers to log and ignore these exceptions. The logs may be helpful for developers working on VM service communication, but not helpful otherwise. Historically, these exceptions were swallowed.

Related Issues

Addresses part of #31813 - see also #28531

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@dnfield dnfield added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 30, 2019
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit c0d5fd2 into flutter:master Apr 30, 2019
@dnfield dnfield deleted the improve_rpc_errors branch April 30, 2019 22:42
dnfield added a commit that referenced this pull request May 1, 2019
dnfield added a commit that referenced this pull request May 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants