-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for replacing the TabController, after disposing the old one #32434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// of this property is [kAlwaysCompleteAnimation]. | ||
Animation<double> get animation => _animationController?.view ?? kAlwaysCompleteAnimation; | ||
final AnimationController _animationController; | ||
/// If the TabController was disposed then return null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// If the TabController was disposed then return null. | |
/// If the [TabController] was disposed then return null. |
expect(controller.length, 3); | ||
expect(find.text('Tab0'), findsOneWidget); | ||
expect(find.text('Tab1'), findsOneWidget); | ||
expect(find.text('Tab2'), findsOneWidget); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you also add an:
expect(find.text('Tab3'), findsOneWidget);
Now that there should be an additional tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm changing the length from 2 - 3
Fixes #32428