-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ThemeData.shadowColor #33257
Add ThemeData.shadowColor #33257
Conversation
…Default stays black to preserve backward compatibility
Well done!!! It would be very useful |
Would be great to see this merged. Any change of fixing those tests? |
@LucasR93, are you still interested in pursuing this PR? If so, you would need to resolve the test failures, and the conflicting files. Also, you will need to add a test for your change that fails without your change, and succeeds with it. |
I suspect that @HansMuller may want the shadow color to go into the ColorScheme rather than the ThemeData? |
Any news update? |
The material color scheme doesn't dictate the appearance of shadows. The approach taken here, adding a property to ThemeData, seems reasonable. @LucasR93 - are you interested in returning to this PR? |
@LucasR93 Do you have any intention to revise this PR and get it merged? |
I am going to close this PR since there hasn't been any activity since the beginning of the year. Feel free to re-open if you find the time to work on this in the future. |
Description
This pull request adds shadowColor to the ThemeData to be able to override the default color of the elevation shadows. The property is used by the Material widget as a fallback, when no shadowColor is supplied to the Material widget. When the user did not override the shadowColor in the Theme, it defaults to black. This way we preserve the backward compatibility all the way to the Material widget.
The priority is the following, going to the next, when null:
Related Issues
#27461
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?