Adds shadowColor property to the Card widget#47273
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Feb 12, 2020
Merged
Adds shadowColor property to the Card widget#47273fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
0dd1d79 to
14bf263
Compare
justinmc
reviewed
Dec 23, 2019
Contributor
justinmc
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think this makes sense. Just one small comment about code order in the test.
@HansMuller Is this alright given the proposed changes to theming?
2e1fe72 to
8a99901
Compare
8a99901 to
e33b098
Compare
HansMuller
reviewed
Jan 16, 2020
e33b098 to
6e64a60
Compare
6e64a60 to
bcb4de4
Compare
Contributor
Author
|
@HansMuller @justinmc is there any other changes needed on this? |
justinmc
approved these changes
Feb 12, 2020
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution and sorry I didn't notice you had updated it! There was one test failure, but it looked like an unrelated timeout to me. I'll rerun that and try to get this merged.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
Thanks @justinmc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new shadowColor property to the Card widget, to allow customizing the shadow color.
Related Issues
#47272
#33257
Tests
I added the following tests:
card_test.dart- added a test that ensures the cards default shadow color is black, and that if a shadowColor is set, the Material shadowColor gets that value.card_theme_test.dart- modified tests to check that the material gets the shadow color from the card theme.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].