Pass an async callback to testWidgets. #33260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dart analyzer fails to warn about this due to a bug that has been fixed but not yet rolled into Flutter (see https://dart-review.googlesource.com/c/sdk/+/100301).
tvolkert
approved these changes
May 23, 2019
stereotype441
changed the title
goderbauer
added
the
framework
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been fixed but not yet rolled into Flutter (see https://dart-review.googlesource.com/c/sdk/+/100301). So it failed to catch that flutter#33217 accidentally introduced a call to `testWidgets` that passed it a synchronous callback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dart analyzer fails to warn about missing returns in function expressions due to a bug that has been
fixed but not yet rolled into Flutter (see
https://dart-review.googlesource.com/c/sdk/+/100301). So it failed to catch that #33217 accidentally introduced a call to
testWidgetsthat passes it a synchronous callback.Related Issues
dart-lang/sdk#28233
Tests
Fixes tests introduced by #33217
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?