fixed 33347 fill the gap during performLayout in SliverGrid and Slive… #33467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
added
the
framework
goderbauer
reviewed
May 29, 2019
| Text('item1', key: Key('1')), | ||
| ] | ||
| )); | ||
| expect(find.text('item0'), findsOneWidget); |
There was a problem hiding this comment.
Should we also assert that the children are in the right position after the re-arrange?
| Text('item2', key: Key('2')), | ||
| ] | ||
| )); | ||
| expect(find.text('item0'), findsOneWidget); |
| }, | ||
| ); | ||
|
|
||
| testWidgets('SliverGrid Correctly layout children after rearranging', (WidgetTester tester) async { |
There was a problem hiding this comment.
SliverGrid -> SliverFixedExtentList ?
| ) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: add a line break at the end of files
goderbauer
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rFixedExtentList
Description
Rearrange sliver children will result in gap in the middle of children list, those gap supposed be filled out during the perform layout. SliverList does fill out the gap while SliverGrid and SliverFixExtentList does not which cause crashes. This PR fixes it
Related Issues
#33347
Tests
I added the following tests:
https://github.com/chunhtai/flutter/blob/1f7ee0e65b86eda45b39a7fd8a3a0908793c337d/packages/flutter/test/widgets/slivers_test.dart#L199
https://github.com/chunhtai/flutter/blob/1f7ee0e65b86eda45b39a7fd8a3a0908793c337d/packages/flutter/test/widgets/slivers_test.dart#L221
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?