Added a benchmark for ImageCache #33814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
a: images
iskakaushik
force-pushed
the
image-cache-benchmark
branch
from
1d05079
to
308e261
Compare
liyuqian
approved these changes
Jun 4, 2019
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| // Once we provide an option for images to be resized to | ||
| // fit the container, we should see a significant drop in |
There was a problem hiding this comment.
nit: two spaces in
a significant
| )); | ||
|
|
||
| await SchedulerBinding.instance.endOfFrame; | ||
| await Future<void>.delayed(const Duration(milliseconds: 50)); |
There was a problem hiding this comment.
Is this waiting for the GPU thread to rasterize the frame? If so, please add a comment here because this is potentially a flaky test. We should change it once we had more reliable mechanism (e.g., Window.onReportTimings in flutter/engine#8983).
This was referenced Jun 6, 2019
kiku-jw
pushed a commit
to kiku-jw/flutter
that referenced
this pull request
Jun 14, 2019
* Add an image cache benchmark for a monochrome image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Benchmarks memory consumed by large images in small containers. This will let us get initial numbers, which we are hoping to improve with: #31164
Related Issues
#26194
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?