New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a benchmark for ImageCache #33814
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
dev/devicelab/bin/tasks/flutter_gallery__image_cache_memory.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright 2016 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async'; | ||
|
|
||
| import 'package:flutter_devicelab/framework/framework.dart'; | ||
| import 'package:flutter_devicelab/framework/utils.dart'; | ||
| import 'package:flutter_devicelab/tasks/perf_tests.dart'; | ||
|
|
||
| Future<void> main() async { | ||
| await task(MemoryTest( | ||
| '${flutterDirectory.path}/examples/flutter_gallery', | ||
| 'test_memory/image_cache_memory.dart', | ||
| 'io.flutter.demo.gallery', | ||
| ).run); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
examples/flutter_gallery/test_memory/image_cache_memory.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Copyright 2016 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // See //dev/devicelab/bin/tasks/flutter_gallery__image_cache_memory.dart | ||
|
|
||
| import 'dart:async'; | ||
|
|
||
| import 'package:flutter/widgets.dart'; | ||
| import 'package:flutter/scheduler.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| // Once we provide an option for images to be resized to | ||
| // fit the container, we should see a significant drop in | ||
| // the amount of memory consumed by this benchmark. | ||
| Future<void> main() async { | ||
| const int numItems = 10; | ||
|
|
||
| runApp(Directionality( | ||
| textDirection: TextDirection.ltr, | ||
| child: ListView.builder( | ||
| key: const Key('ImageList'), | ||
| itemCount: numItems, | ||
| itemBuilder: (BuildContext context, int position) { | ||
| return Container( | ||
| width: 200, | ||
| height: 200, | ||
| child: Center( | ||
| child: Image.asset( | ||
| 'monochrome/red-square-1024x1024.png', | ||
| package: 'flutter_gallery_assets', | ||
| width: 100, | ||
| height: 100, | ||
| fit: BoxFit.contain, | ||
| key: Key('image_$position'), | ||
| ), | ||
| ), | ||
| ); | ||
| }, | ||
| ), | ||
| )); | ||
|
|
||
| await SchedulerBinding.instance.endOfFrame; | ||
|
|
||
| // We are waiting for the GPU to rasterize a frame here. This makes this flaky, | ||
| // we can rely on a more deterministic such as `Window.onReportTimings` once | ||
| // https://github.com/flutter/flutter/issues/26154 is addressed. | ||
| await Future<void>.delayed(const Duration(milliseconds: 50)); | ||
| debugPrint('==== MEMORY BENCHMARK ==== READY ===='); | ||
|
|
||
| final WidgetController controller = | ||
| LiveWidgetController(WidgetsBinding.instance); | ||
|
|
||
| debugPrint('Scrolling...'); | ||
| final Finder list = find.byKey(const Key('ImageList')); | ||
| final Finder lastItem = find.byKey(const Key('image_${numItems - 1}')); | ||
| do { | ||
| await controller.drag(list, const Offset(0.0, -30.0)); | ||
| await Future<void>.delayed(const Duration(milliseconds: 20)); | ||
| } while (!lastItem.precache()); | ||
|
|
||
| debugPrint('==== MEMORY BENCHMARK ==== DONE ===='); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this waiting for the GPU thread to rasterize the frame? If so, please add a comment here because this is potentially a flaky test. We should change it once we had more reliable mechanism (e.g.,
Window.onReportTimingsin flutter/engine#8983).