Update Dark Theme disabledColor to White38 #35136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihaohong
added
framework
|
I'll hold off on sending the breaking change email until I've gotten some PR feedback on this just to make sure that everything seems ok |
rami-a
reviewed
Jul 3, 2019
| @@ -470,7 +470,7 @@ class ButtonThemeData extends Diagnosticable { | |||
|
|
|||
| Color _getDisabledColor(MaterialButton button) { | |||
| return getBrightness(button) == Brightness.dark | |||
| ? colorScheme.onSurface.withOpacity(0.30) // default == Colors.white30 | |||
| ? colorScheme.onSurface.withOpacity(0.38) // default == Colors.white38 | |||
There was a problem hiding this comment.
Both conditions in are now the same here, so the conditional is unnecessary
There was a problem hiding this comment.
Made the fix, as well as updated the API docs since I missed updating those as well
HansMuller
approved these changes
Jul 3, 2019
| @@ -489,7 +483,7 @@ class ButtonThemeData extends Diagnosticable { | |||
| return button.textColor; | |||
| if (button.disabledTextColor != null) | |||
| return button.disabledTextColor; | |||
| return _getDisabledColor(button); | |||
| return colorScheme.onSurface.withOpacity(0.38); | |||
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* Add Colors.white38 * Update ThemeData.disabledColor and ButtonThemeData.disabledColor to Colors.white38 * Update pre-existing tests to expect Colors.white38 instead of Colors.white30 * Update API documentation to reflect these changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Dark Theme in Material sets disabled states to Colors.white30. However, according to the Material Design specs for dark theme, it should be White 38% instead. This PR reflects this change.
Related Issues
Addresses #33149
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
Yes, this is a breaking change (Please read Handling breaking changes).
No, this is not a breaking change.