Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorFilterLayer/Widget #35468

Merged
merged 9 commits into from Jul 11, 2019
Merged

Add colorFilterLayer/Widget #35468

merged 9 commits into from Jul 11, 2019

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 2, 2019

Description

Adds a ColorFilter layer and widget. customer: octopod would like to use this to preview color blindness filters on widget trees.

Depends on flutter/engine#9641 - tests will fail until that rolls in.

Related Issues

Fixes #5692

Tests

I added the following tests:

Test that ColorFilterLayer does the right thing when it changes.

Golden tests for ColorFiltered widget.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change (though the upstream engine change is).

@dnfield dnfield added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: octopod framework flutter/packages/flutter repository. See also f: labels. and removed cla: yes labels Jul 2, 2019
@dnfield
Copy link
Contributor Author

dnfield commented Jul 8, 2019

/cc @emshack - this should enable doing the color filter previewing of widget trees. It's waiting on the upstream engine change, which should hopefully land soon.

@dnfield dnfield marked this pull request as ready for review July 11, 2019 07:33
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo minor documentation nit

@dnfield dnfield merged commit 7a20148 into flutter:master Jul 11, 2019
@dnfield dnfield deleted the color_filter branch July 11, 2019 22:49
@dnfield
Copy link
Contributor Author

dnfield commented Jul 11, 2019

Oh man I could have sworn the build was green when I merged this. Whups.

johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: octopod framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ColorFilter widget
3 participants