New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colorFilterLayer/Widget #35468
Merged
Merged
Add colorFilterLayer/Widget #35468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
customer: octopod
framework
flutter/packages/flutter repository. See also f: labels.
and removed
cla: yes
labels
Jul 2, 2019
/cc @emshack - this should enable doing the color filter previewing of widget trees. It's waiting on the upstream engine change, which should hopefully land soon. |
collinjackson
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo minor documentation nit
Co-Authored-By: Collin Jackson <jackson@google.com>
Oh man I could have sworn the build was green when I merged this. Whups. |
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
customer: octopod
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a ColorFilter layer and widget. customer: octopod would like to use this to preview color blindness filters on widget trees.
Depends on flutter/engine#9641 - tests will fail until that rolls in.
Related Issues
Fixes #5692
Tests
I added the following tests:
Test that ColorFilterLayer does the right thing when it changes.
Golden tests for ColorFiltered widget.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?