Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing to screenshot and printDetails method #36418

Merged
merged 1 commit into from Jul 18, 2019

Conversation

jonahwilliams
Copy link
Member

Description

Note: Apologies for large diff due to removal of unnecessary group.

To facilitate the eventual refactor of resident_runner, it must be thoroughly unit tested. In this PR I attempted to add test cases for the invariants of the screenshot method, adding documentation, as well as a rough smoke test of print help.

@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 18, 2019
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #36418 into master will increase coverage by 1.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36418      +/-   ##
==========================================
+ Coverage   54.03%   55.63%   +1.59%     
==========================================
  Files         188      188              
  Lines       17344    17346       +2     
==========================================
+ Hits         9372     9650     +278     
+ Misses       7972     7696     -276
Flag Coverage Δ
#flutter_tool 55.63% <100%> (+1.59%) ⬆️
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/resident_runner.dart 45.18% <100%> (+7.55%) ⬆️
...ckages/flutter_tools/lib/src/ios/code_signing.dart 96.87% <0%> (-1.57%) ⬇️
packages/flutter_tools/lib/src/version.dart 96.05% <0%> (-1.48%) ⬇️
packages/flutter_tools/lib/src/build_info.dart 69.61% <0%> (-1.11%) ⬇️
...s/flutter_tools/lib/src/test/flutter_platform.dart 28.64% <0%> (-0.28%) ⬇️
.../flutter_tools/lib/src/android/android_device.dart 31.37% <0%> (-0.26%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 39.13% <0%> (+0.31%) ⬆️
...ges/flutter_tools/lib/src/application_package.dart 66.54% <0%> (+1.12%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 82.81% <0%> (+1.56%) ⬆️
packages/flutter_tools/lib/src/run_hot.dart 48.68% <0%> (+2.85%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578204d...db9da0c. Read the comment docs.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 1957c66 into flutter:master Jul 18, 2019
@jonahwilliams jonahwilliams deleted the resident_runnerz branch July 18, 2019 17:40
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants