Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip date_picker_test on Windows as underlying issue 19696 was fixed. #36546

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

aam
Copy link
Member

@aam aam commented Jul 19, 2019

Fix for https://github.com/flutter/flutter#19696 landed as part of engine/dart sdk roll #36386 (dart-lang/sdk@7139a2ab3a).

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 19, 2019
@aam aam requested a review from dnfield July 19, 2019 16:16
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aam aam merged commit d28f3c7 into flutter:master Jul 22, 2019
@aam aam deleted the unskip-date-picker-test-win branch July 22, 2019 20:55
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants