Add texture header file unpack command to flutter_tools for GLFW shell (#30718). #36818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
|
Marking work in progress while waiting for the engine PRs to land. |
jmagman
reviewed
Jan 15, 2020
| @@ -41,6 +41,7 @@ const Target unpackWindows = Target( | |||
| Source.pattern('{PROJECT_DIR}/windows/flutter/flutter_export.h'), | |||
| Source.pattern('{PROJECT_DIR}/windows/flutter/flutter_messenger.h'), | |||
| Source.pattern('{PROJECT_DIR}/windows/flutter/flutter_plugin_registrar.h'), | |||
| Source.pattern('{PROJECT_DIR}/linux/flutter/flutter_texture_registrar.h'), | |||
|
@cloudwebrtc what is the status of this PR? |
zanderso
moved this from Awaiting triage
to Engineer reviewed
in Tools - engine support review
|
Because of the lack of activity on this PR I'm going to close it to remove from our review queue. Please feel free to send us a new PR or discuss in an issue anytime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #30718
Depends on the following:
flutter/engine#9822
flutter/buildroot#275
Related Issues
#30718
Tests
I did the tests on Windows 10 x64 and Ubuntu Linux 16.04 x64.
Correctly copy flutter_texture_registrar.h from src/out/host_debug and complete the flutter app compilation.
Use the following command:
flutter build linux --local-engine=host_debug --debugflutter build windows --local-engine=host_debug --debugChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?