Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo: Modal dismissed by any button #36956

Merged

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 25, 2019

Description

This is a redo of #32770, which was reverted because it was found to break apps in the following scenario:

  • When there is a translucent Listener stacked on it that detects drags, the drag will always be rejected, because _AnyTapGestureRecognizer instantly claims victory to all PointerDownEvents.

This PR rewrites _AnyTapGestureRecognizer based on TapGestureRecognizer, which means it now competes in the arena with the same rule as normal taps.

It also adds a test that sets up the aforementioned scenario, which is failed by the previous implementation and passed by the new implementation.

Related Issues

Tests

I added the following tests:

  • ModalBarrier does not prevent interactions with translucent widgets in front of it

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 25, 2019
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkwingsmt dkwingsmt merged commit 24f483c into flutter:master Jul 29, 2019
@dkwingsmt dkwingsmt deleted the redo-modal-dismissed-by-any-button branch July 29, 2019 04:44
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
This PR makes ModalBarrier dismiss modal with any button press instead of primary button up, by making it use a private recognizer _AnyTapGestureRecognizer that is similar to TapGestureRecognizer but accepts gestures by any single button.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants