Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabling post-submit gold tests on mac #38326

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 12, 2019

Description

This PR re-enables the other and widget testing shards for Mac, while only executing in post-submit. The removal of these test shards disabled golden file testing for Mac.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 12, 2019
.cirrus.yml Outdated Show resolved Hide resolved
@Piinks Piinks requested a review from dnfield August 12, 2019 17:20
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @tvolkert fyi

@Piinks Piinks changed the title Re-enabling gold tests on mac Re-enabling post-submit gold tests on mac Aug 12, 2019
@Piinks Piinks merged commit 59a570f into flutter:master Aug 12, 2019
@Piinks Piinks deleted the macGold branch November 22, 2019 00:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants