Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better docs for text (ready to land) #38922

Merged
merged 1 commit into from Aug 28, 2019
Merged

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 20, 2019

No description provided.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 20, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cirrus is unhappy.

@Hixie Hixie force-pushed the text-docs branch 2 times, most recently from f3419a2 to b62b067 Compare August 23, 2019 18:26
@Hixie Hixie changed the title Better docs for text Better docs for text (ready to land) Aug 25, 2019
@goderbauer goderbauer merged commit ddd31bc into flutter:master Aug 28, 2019
jonahwilliams added a commit that referenced this pull request Aug 28, 2019
jonahwilliams added a commit that referenced this pull request Aug 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants