Fix a problem with disposing of focus nodes in tab scaffold #40100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: cupertino
HansMuller
approved these changes
Sep 10, 2019
| ); | ||
| if (tabFocusNodes.length != widget.tabCount) { | ||
| if (tabFocusNodes.length > widget.tabCount) { | ||
| discardedNodes.addAll(tabFocusNodes.sublist(widget.tabCount, tabFocusNodes.length)); |
There was a problem hiding this comment.
I think this is the same as:
discardedNodes.addAll(tabFocusNodes.sublist(widget.tabCount));
Although, what you've written is probably clearer :-).
There was a problem hiding this comment.
Yes, you're right. I'll switch it to yours, since it's more succinct (and probably more canonical).
| tabFocusNodes.addAll( | ||
| List<FocusScopeNode>.generate( | ||
| widget.tabCount - tabFocusNodes.length, | ||
| (int index) => FocusScopeNode(debugLabel: '${describeIdentity(widget)} Tab ${index + tabFocusNodes.length}'), |
| List<FocusScopeNode> tabFocusNodes; | ||
| final List<bool> shouldBuildTab = <bool>[]; | ||
| final List<FocusScopeNode> tabFocusNodes = <FocusScopeNode>[]; | ||
| final List<FocusScopeNode> discardedNodes = <FocusScopeNode>[]; |
There was a problem hiding this comment.
It seems odd that we don't eagerly dispose discarded nodes. Maybe explain why we hang on to them until the enclosing widget is disposed, here.
gspencergoog
force-pushed
the
fix_tab_scaffold
branch
2 times, most recently
from
ab4b8e7
to
cfb9778
Compare
gspencergoog
force-pushed
the
fix_tab_scaffold
branch
from
cfb9778
to
71531b9
Compare
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…40100) Previously, focus nodes created in the tab scaffold were not being disposed of properly, causing possible memory leaks. Also, the builder wasn't being passed the right context so that the FocusScope.of operator inside of a builder would find the focus scope for the given tab (it was being passed the context of the overall tab scaffold).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, focus nodes created in the tab scaffold were not being disposed of properly, causing possible memory leaks. Also, the builder wasn't being passed the right context so that the FocusScope.of operator inside of a builder would find the focus scope for the given tab (it was being passed the context of the overall tab scaffold).
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?