Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tool] Report rss high watermark in command analytics events #40988

Merged
merged 2 commits into from
Sep 25, 2019
Merged

[flutter_tool] Report rss high watermark in command analytics events #40988

merged 2 commits into from
Sep 25, 2019

Conversation

zanderso
Copy link
Member

Description

This PR adds memory high watermark information in command completion events. This is a step toward determining whether long-running tool commands have high memory usage.

Related Issues

Reports from twitter

Tests

I added the following tests:

Added a test to flutter_command_test.dart.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@zanderso zanderso added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #40988 into master will decrease coverage by 0.81%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40988      +/-   ##
==========================================
- Coverage   60.58%   59.77%   -0.82%     
==========================================
  Files         192      192              
  Lines       18649    18663      +14     
==========================================
- Hits        11299    11155     -144     
- Misses       7350     7508     +158
Flag Coverage Δ
#flutter_tool 59.77% <85.71%> (-0.82%) ⬇️
Impacted Files Coverage Δ
...ckages/flutter_tools/lib/src/reporting/events.dart 96.82% <100%> (+0.27%) ⬆️
...ackages/flutter_tools/lib/src/reporting/usage.dart 85.33% <100%> (-3.93%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 71.42% <100%> (+0.51%) ⬆️
packages/flutter_tools/lib/src/base/io.dart 53.33% <71.42%> (+3.33%) ⬆️
packages/flutter_tools/lib/src/ios/devices.dart 36.28% <0%> (-29.12%) ⬇️
...s/flutter_tools/lib/src/windows/visual_studio.dart 73.52% <0%> (-20.59%) ⬇️
...ages/flutter_tools/lib/src/protocol_discovery.dart 86.2% <0%> (-10.35%) ⬇️
packages/flutter_tools/lib/src/convert.dart 58.33% <0%> (-8.34%) ⬇️
packages/flutter_tools/lib/src/asset.dart 78.9% <0%> (-6.76%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a476a...74f858d. Read the comment docs.

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanderso zanderso merged commit 5142238 into flutter:master Sep 25, 2019
@zanderso zanderso deleted the command-max-rss branch September 25, 2019 18:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants