-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bad indentations(mainly around collection literals) #41355
Conversation
Codecov Report
@@ Coverage Diff @@
## master #41355 +/- ##
==========================================
- Coverage 60.45% 59.59% -0.86%
==========================================
Files 192 192
Lines 18724 18723 -1
==========================================
- Hits 11319 11158 -161
- Misses 7405 7565 +160
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rect: const Rect.fromLTRB(0.0, 0.0, 48.0, 48.0), | ||
children: <TestSemantics>[], | ||
), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should there be a trailing comma here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a rule to lint missing trailing commas but (for now) I made an exception to make it only lint missing trailing commas if the argument list has a length > 1. That's why there's still a missing trailing comma here.
This exception is here to allow things like:
information.add(ErrorDescription(
'The test API method "${originalGuarder.methodName}" '
'from class ${originalGuarder.className} '
'was called from ${originalGuarder.callerFile} '
'on line ${originalGuarder.callerLine}, '
'but never completed before its parent scope closed.' // there should be a trailing comma here
));
From dartfmt POV there should be a trailing comma to keep this kind of formatting. Perhaps/eventually the rule should remove the exception. WDYT?
Description
fix some bad indentations (mainly around collection literals) in
packages/flutter/
andpackages/flutter_tools/
Related Issues
None
Tests
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?