Always fake ProcessManager when you fake Filesystem in tests #42369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
|
cc @jonahwilliams this fixes the ThrowingPub layering issue too |
Codecov Report
@@ Coverage Diff @@
## master #42369 +/- ##
==========================================
- Coverage 60.48% 59.38% -1.11%
==========================================
Files 194 194
Lines 18856 18856
==========================================
- Hits 11405 11197 -208
- Misses 7451 7659 +208
Continue to review full report at Codecov.
|
zanderso
reviewed
Oct 10, 2019
| // Copyright 2016 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
There was a problem hiding this comment.
Cool, thanks. This is a really nice API, but it doesn't appear to have any non-trivial uses in this PR. What are your plans for it?
There was a problem hiding this comment.
My first customer is #42491. I suspect the API will evolve as it gets more users.
Hixie
force-pushed
the
pubspec.timestamp
branch
2 times, most recently
from
68abb15
to
9e5d2e2
Compare
...because otherwise, processes that think they're manipulating your filesystem will be doing crazy things the test is ignoring, leading to (at best) failures and (at worst) flakes or disk corruption.
Hixie
force-pushed
the
pubspec.timestamp
branch
from
9e5d2e2
to
fce8013
Compare
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…#42369) ...because otherwise, processes that think they're manipulating your filesystem will be doing crazy things the test is ignoring, leading to (at best) failures and (at worst) flakes or disk corruption.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.