Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Gradle on Windows #42709

Merged
merged 6 commits into from
Oct 21, 2019
Merged

Test Gradle on Windows #42709

merged 6 commits into from
Oct 21, 2019

Conversation

blasten
Copy link

@blasten blasten commented Oct 15, 2019

Enable Gradle tests on Windows.
I chatted with @dnfield about this a while back.

Fixes #36311

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Oct 15, 2019
@blasten blasten requested a review from mklim October 15, 2019 05:18
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #42709 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42709      +/-   ##
==========================================
- Coverage   61.23%   61.22%   -0.02%     
==========================================
  Files         195      195              
  Lines       18954    18954              
==========================================
- Hits        11606    11604       -2     
- Misses       7348     7350       +2
Flag Coverage Δ
#flutter_tool 61.22% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
...kages/flutter_tools/lib/src/commands/generate.dart 11.11% <0%> (-74.08%) ⬇️
...ckages/flutter_tools/lib/src/commands/channel.dart 43.07% <0%> (-29.24%) ⬇️
packages/flutter_tools/lib/src/base/build.dart 60.5% <0%> (-15.13%) ⬇️
...ges/flutter_tools/lib/src/build_system/source.dart 79.59% <0%> (-4.09%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 77.92% <0%> (-3.9%) ⬇️
packages/flutter_tools/lib/src/codegen.dart 5.63% <0%> (-1.41%) ⬇️
packages/flutter_tools/lib/src/compile.dart 77.89% <0%> (-0.69%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 82.75% <0%> (-0.39%) ⬇️
packages/flutter_tools/lib/src/cache.dart 48.47% <0%> (-0.24%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 41.5% <0%> (+0.33%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c535de...3c57c2d. Read the comment docs.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself LGTM, RSLGTM for Windows no longer crashing. :)

@blasten blasten force-pushed the gradle_windows branch 12 times, most recently from 3d7700d to cc1f326 Compare October 18, 2019 23:41
@blasten blasten merged commit 30493a3 into flutter:master Oct 21, 2019
@blasten blasten deleted the gradle_windows branch October 21, 2019 23:42
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devicelab uses unzip (which isn't available on Windows)
4 participants