Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we can disable --track-widget-creation in debug mode #43016

Merged
merged 2 commits into from Oct 18, 2019

Conversation

jonahwilliams
Copy link
Member

Description

Though it is still on by default, allow it to be toggled off.

Fixes #43014

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #43016 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43016      +/-   ##
==========================================
+ Coverage   60.55%   60.86%   +0.31%     
==========================================
  Files         195      195              
  Lines       18940    18940              
==========================================
+ Hits        11469    11528      +59     
+ Misses       7471     7412      -59
Flag Coverage Δ
#flutter_tool 60.86% <100%> (+0.31%) ⬆️
Impacted Files Coverage Δ
...utter_tools/lib/src/build_system/targets/dart.dart 47% <100%> (+0.53%) ⬆️
packages/flutter_tools/lib/src/bundle.dart 85.71% <100%> (+0.25%) ⬆️
...s/flutter_tools/lib/src/test/flutter_platform.dart 0.55% <0%> (-27.5%) ⬇️
...ackages/flutter_tools/lib/src/commands/unpack.dart 6.49% <0%> (-24.68%) ⬇️
packages/flutter_tools/lib/src/version.dart 93.23% <0%> (-1.94%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 40.83% <0%> (-1%) ⬇️
packages/flutter_tools/lib/src/cache.dart 48.47% <0%> (-0.71%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 51.35% <0%> (+0.9%) ⬆️
packages/flutter_tools/lib/src/run_cold.dart 43.52% <0%> (+1.17%) ⬆️
packages/flutter_tools/lib/src/codegen.dart 7.04% <0%> (+1.4%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1982a5c...1d2606b. Read the comment docs.

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Great to see this enabled by default with an escape hatch.

@jonahwilliams jonahwilliams merged commit e67f9a3 into flutter:master Oct 18, 2019
@jonahwilliams jonahwilliams deleted the fix_track_widget_creation branch October 18, 2019 19:40
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track widget creation is not respected by the flutter build commands
4 participants