Add a Flutter command that builds an APK using a local build of the e… #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,6 +113,16 @@ class FlutterCommandRunner extends CommandRunner { | |||
| } | |||
| List<BuildConfiguration> _buildConfigurations; | |||
|
|
|||
| String get enginePath { | |||
There was a problem hiding this comment.
I think it'd be better to use the BuildConfiguration logic, and loop through and build the APK for all the relevant builds, the same way that "flutter test --debug --release" tests both debug and release builds. In particular, how do you know whether to use debug or release builds this way?
There was a problem hiding this comment.
Discussed this and decided on a policy of using the first BuildConfiguration having Android as the target platform.
jason-simmons
force-pushed
the
apk_package
branch
from
60969b1
to
408c345
Compare
|
LGTM. Note: Travis is mad. |
| } | ||
|
|
||
| BuildConfiguration config = buildConfigurations.firstWhere( | ||
| (BuildConfiguration bc) => bc.targetPlatform == TargetPlatform.android); |
|
LGTM, just some minor nits. |
jason-simmons
force-pushed
the
apk_package
branch
from
408c345
to
83540c0
Compare
…ngine Example: cd flutter/examples/stocks flutter --engine-src-path /path/to/engine/src apk -o Stocks.apk -m apk/AndroidManifest.xml
jason-simmons
force-pushed
the
apk_package
branch
from
83540c0
to
0755642
Compare
jason-simmons
added a commit
that referenced
this pull request
Nov 17, 2015
Add a Flutter command that builds an APK using a local build of the e…
This was referenced Jan 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngine
Example:
cd flutter/examples/stocks
flutter --engine-src-path /path/to/engine/src apk -o Stocks.apk -m apk/AndroidManifest.xml