Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the plugin registrant to io.flutter.plugins and add the @Keep an… #44011

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

blasten
Copy link

@blasten blasten commented Nov 1, 2019

Description

This PR moves the plugin registrant back to the io.flutter.plugins namespace and adds the @keep annotation, so the class isn't removed by R8.

Related Issues

Fixes #43869

Tests

I added the following tests: Updated the unit test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 1, 2019
@blasten blasten merged commit ade8dfa into flutter:master Nov 1, 2019
@blasten blasten deleted the plugin_registrant branch November 1, 2019 23:58
@blasten
Copy link
Author

blasten commented Nov 1, 2019

@RedBrogdon fyi, the examples now need to import io.flutter.plugins.GeneratedPluginRegistrant instead of dev.flutter.plugins.GeneratedPluginRegistrant.

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @Keep annotation to the plugin registrant
4 participants