Properly interpret modifiers on GLFW key events #44844
Conversation
gspencergoog
added
platform-linux
fluttergithubbot
added
the
framework
gspencergoog
force-pushed
the
fix_glfw_modifiers
branch
from
a7fe2ad
to
cdaa9fa
Compare
| static const int modifierNumericPad = 0x0020; | ||
|
|
||
| int _mergeModifiers({int modifiers, int keyCode, bool isDown}) { |
There was a problem hiding this comment.
So my understanding is correct: The flutter keyboard code treats the modifiers as containing the current modifier key info, like if you press left control. But GLFW doesn't include this info, so it would send a modifier without the left control info. Here you are normalizing it by updating the modifier with the current key info?
There was a problem hiding this comment.
Yes, more or less. More accurately, GLFW just sends the value of modifiers as the state before the current event, so it lags. All the other platforms set the state of the modifier including the effect of the current event.
|
|
||
| int modifierChange = 0; | ||
| switch (keyCode) { | ||
| case 341: // controlLeft |
There was a problem hiding this comment.
Should these keycodes have constants that could be used?
gspencergoog
force-pushed
the
fix_glfw_modifiers
branch
from
cdaa9fa
to
b08e525
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Description
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account.
As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicated.
Tests
Breaking Change