Don't log stack traces to console on build failures #44966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
darielopper
approved these changes
Nov 15, 2019
|
@dramosv90 I don't mind you leaving feedback or asking questions on PRs, but please don't leave empty approvals |
zanderso
reviewed
Nov 15, 2019
| @@ -156,7 +156,7 @@ class AssembleCommand extends FlutterCommand { | |||
| )); | |||
| if (!result.success) { | |||
| for (MapEntry<String, ExceptionMeasurement> data in result.exceptions.entries) { | |||
| printError('Target ${data.key} failed: ${data.value.exception}', stackTrace: data.value.stackTrace); | |||
| printError('Target ${data.key} failed: ${data.value.exception}'); | |||
There was a problem hiding this comment.
Two comments:
- I'm seeing a few other potentially similar cases in aot.dart, bundle.dart, and web/compile.dart.
- Is there any way that an
ExceptionMeasurementcan indicate whether the stack trace should be printed?
zanderso
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are confusing when there is a compilation error, as it seems like the tool has failed.
Fixes #44963