Add a perf test for picture raster cache #45050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
team
liyuqian
added
c: performance
This will catch issues like flutter#44252, and this test is inspired by the `list_demo` sample app in flutter#43083 (comment) This is tested locally on a Moto G4 before and after the fix flutter/engine#13710 The `average_frame_rasterizer_time_millis` of this test drops from ~5.4ms to ~4.9ms after that fix.
chinmaygarde
approved these changes
Nov 18, 2019
liyuqian
added a commit
to flutter/engine
that referenced
this pull request
Nov 21, 2019
Previously, we're also counting the pictures that are already raster cached. This fixes flutter/flutter#44252 and helps solving the GPU thread issue of flutter/flutter#43083 flutter/flutter#45050 is a performance test in the framework repo to reveal this bug.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch issues like
#44252, and this test is
inspired by the
list_demosample app in#43083 (comment)
This is tested locally on a Moto G4 before and after the fix
flutter/engine#13710
The
average_frame_rasterizer_time_millisof this test drops from~5.4ms to ~4.9ms after that fix.