Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always re-copy Framework/podspec for iOS module project #45877

Merged
merged 4 commits into from Dec 10, 2019
Merged

Always re-copy Framework/podspec for iOS module project #45877

merged 4 commits into from Dec 10, 2019

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Dec 2, 2019 •
edited

Description

When deleting the ephemeral directory for an iOS module project, recopy a debug Framework and podspec into the ephemeral directory so that the next run of cocoapods does not fail.

fixes #42956

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Dec 2, 2019
@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Dec 6, 2019
@jonahwilliams jonahwilliams marked this pull request as ready for review December 6, 2019 03:10
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman
jmagman approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this looks so much like #37450 except copied instead of symlinked, which I don't think should matter (though copying is a much better idea). I wonder why that one didn't pass but this one did...

LGTM and thanks for doing this!

@jonahwilliams
Copy link
Member Author

@jmagman How flaky was the test previously? Should I be able to tell that this is "fixed" fixed in 2/5/10 runs?

@jmagman
Copy link
Member

jmagman commented Dec 6, 2019

@jmagman How flaky was the test previously? Should I be able to tell that this is "fixed" fixed in 2/5/10 runs?

If I recall, unscientifically... 3-4 times? 😅

@jonahwilliams jonahwilliams changed the title [WIP] Always re-copy Framework/podspec for iOS module project Always re-copy Framework/podspec for iOS module project Dec 9, 2019
@jonahwilliams jonahwilliams merged commit 523ac7b into flutter:master Dec 10, 2019
@jonahwilliams jonahwilliams deleted the module_stuffx branch December 10, 2019 05:18
@jmagman jmagman mentioned this pull request Dec 11, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build iOS app after modifying pubspec.yaml and running flutter pub get
4 participants
@jonahwilliams @fluttergithubbot @jmagman @googlebot