Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land "Add option to delay rendering the first frame (#45135)" #45941

Merged

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 2, 2019

Description

With fixed copyright headers.

Related Issues

See original PR (#45588).

Tests

I added the following tests:

See original PR (#45588).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Dec 2, 2019
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Dec 2, 2019
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docs/string nits.
32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

packages/flutter/lib/src/rendering/binding.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/rendering/binding.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/rendering/binding.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/rendering/binding.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/rendering/binding.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/binding.dart Show resolved Hide resolved
packages/flutter/lib/src/widgets/binding.dart Show resolved Hide resolved
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

goderbauer and others added 5 commits December 2, 2019 15:33
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: API break Backwards-incompatible API changes framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants