-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-land "Add option to delay rendering the first frame (#45135)" #45941
Merged
fluttergithubbot
merged 7 commits into
flutter:master
from
goderbauer:revertrevertagainandagain
Dec 4, 2019
Merged
Re-land "Add option to delay rendering the first frame (#45135)" #45941
fluttergithubbot
merged 7 commits into
flutter:master
from
goderbauer:revertrevertagainandagain
Dec 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter#45135)" (flutter#45588)" (flutter#45939)" This reverts commit cd052a5.
fluttergithubbot
added
a: tests
"flutter test", flutter_test, or one of our tests
framework
flutter/packages/flutter repository. See also f: labels.
labels
Dec 2, 2019
gspencergoog
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Piinks
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-Authored-By: Greg Spencer <gspencergoog@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: tests
"flutter test", flutter_test, or one of our tests
c: API break
Backwards-incompatible API changes
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With fixed copyright headers.
Related Issues
See original PR (#45588).
Tests
I added the following tests:
See original PR (#45588).
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?