Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support --fast-start for Android applications (as an opt-in)" #46138

Merged
merged 1 commit into from Dec 5, 2019
Merged

Revert "Support --fast-start for Android applications (as an opt-in)" #46138

merged 1 commit into from Dec 5, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 5, 2019

Reverts #45431

This caused test failures post-submit

14:04 +1603 ~5: test/commands.shard/hermetic/run_test.dart: run dart-flags option is populated in debug mode                                                                                           UnimplementedError: supportsFastStart
#0      Fake.noSuchMethod (package:mockito/src/mock.dart:206:5)
#1      FakeDevice.supportsFastStart (package:flutter_tools/src/device.dart:424:12)
#2      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:402:19)
<asynchronous suspension>
#3      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:620:18)
<asynchronous suspension>
#4      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:516:33)
<asynchronous suspension>
#5      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:146:29)
#6      _rootRun (dart:async/zone.dart:1126:13)
#7      _CustomZone.run (dart:async/zone.dart:1023:19)
#8      _runZoned (dart:async/zone.dart:1518:10)
#9      runZoned (dart:async/zone.dart:1465:12)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:145:18)
#11     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:506:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:333:21)
<asynchronous suspension>
#14     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:146:29)
#15     _rootRun (dart:async/zone.dart:1126:13)
#16     _CustomZone.run (dart:async/zone.dart:1023:19)
#17     _runZoned (dart:async/zone.dart:1518:10)
#18     runZoned (dart:async/zone.dart:1465:12)
#19     AppContext.run (package:flutter_tools/src/base/context.dart:145:18)
#20     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:284:19)
#21     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#22     new Future.sync (dart:async/future.dart:224:31)
#23     CommandRunner.run (package:args/command_runner.dart:112:14)
#24     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:227:18)
#25     main.<anonymous closure>.<anonymous closure>.<anonymous closure> (org-dartlang-app:///test/commands.shard/hermetic/run_test.dart:233:50)
#26     testUsingContext.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (org-dartlang-app:///test/src/context.dart:133:42)
#27     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:146:29)
#28     _rootRun (dart:async/zone.dart:1126:13)
#29     _CustomZone.run (dart:async/zone.dart:1023:19)
#30     _runZoned (dart:async/zone.dart:1518:10)
#31     runZoned (dart:async/zone.dart:1465:12)
#32     AppContext.run (package:flutter_tools/src/base/context.dart:145:18)
#33     testUsingContext.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (org-dartlang-app:///test/src/context.dart:122:30)
#34     _rootRun (dart:async/zone.dart:1126:13)
#35     _CustomZone.run (dart:async/zone.dart:1023:19)
#36     _runZoned (dart:async/zone.dart:1518:10)
#37     runZoned (dart:async/zone.dart:1502:12)
#38     testUsingContext.<anonymous closure>.<anonymous closure>.<anonymous closure> (org-dartlang-app:///test/src/context.dart:120:18)
#39     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:146:29)
#40     _rootRun (dart:async/zone.dart:1126:13)
#41     _CustomZone.run (dart:async/zone.dart:1023:19)
#42     _runZoned (dart:async/zone.dart:1518:10)
#43     runZoned (dart:async/zone.dart:1465:12)
#44     AppContext.run (package:flutter_tools/src/base/context.dart:145:18)
#45     testUsingContext.<anonymous closure>.<anonymous closure> (org-dartlang-app:///test/src/context.dart:91:22)
#46     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:146:29)
#47     _rootRun (dart:async/zone.dart:1126:13)
#48     _CustomZone.run (dart:async/zone.dart:1023:19)
#49     _runZoned (dart:async/zone.dart:1518:10)
#50     runZoned (dart:async/zone.dart:1465:12)
#51     AppContext.run (package:flutter_tools/src/base/context.dart:145:18)
#52     runInContext (package:flutter_tools/src/context_runner.dart:64:24)
#53     testUsingContext.<anonymous closure> (org-dartlang-app:///test/src/context.dart:90:11)
#54     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:171:27)
<asynchronous suspension>
#55     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:242:15)
#56     _rootRun (dart:async/zone.dart:1126:13)
#57     _CustomZone.run (dart:async/zone.dart:1023:19)
#58     _runZoned (dart:async/zone.dart:1518:10)
#59     runZoned (dart:async/zone.dart:1465:12)
#60     Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:239:5)
#61     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:169:33)
#62     _rootRun (dart:async/zone.dart:1126:13)
#63     _CustomZone.run (dart:async/zone.dart:1023:19)
#64     _runZoned (dart:async/zone.dart:1518:10)
#65     runZoned (dart:async/zone.dart:1465:12)
#66     Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:13)
#67     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:392:25)
#68     new Future.<anonymous closure> (dart:async/future.dart:176:37)
#69     StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#70     StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48)
#71     _rootRun (dart:async/zone.dart:1122:38)
#72     _CustomZone.run (dart:async/zone.dart:1023:19)
#73     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#74     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#75     StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#76     StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48)
#77     _rootRun (dart:async/zone.dart:1126:13)
#78     _CustomZone.run (dart:async/zone.dart:1023:19)
#79     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:949:23)
#80     Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:23:15)
#81     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:384:19)
#82     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:418:5)
#83     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:174:12)

main.log.txt

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 5, 2019
jonahwilliams
jonahwilliams approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Dec 5, 2019

Landing on red to green out the build.

@jmagman jmagman merged commit d01de94 into master Dec 5, 2019
@jmagman jmagman deleted the revert-45431-_fast_start branch December 5, 2019 02:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
d: examples Sample code and demos team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmagman @jonahwilliams @googlebot @fluttergithubbot