Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward device vmservice port to iOS launch arguments #46822

Merged
merged 1 commit into from Dec 12, 2019
Merged

Forward device vmservice port to iOS launch arguments #46822

merged 1 commit into from Dec 12, 2019

Conversation

jonahwilliams
Copy link
Member

Description

This allows the tool to force the iOS application to either launch the observatory on a given port, or die trying.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 12, 2019
zanderso
zanderso approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it would be unreliable to use, but it is probably the only option we can offer for iOS 13 in environments where the mDNS query doesn't work.

@jonahwilliams jonahwilliams merged commit 8ca5560 into flutter:master Dec 12, 2019
@jonahwilliams jonahwilliams deleted the device_port_stuff_ios branch December 12, 2019 21:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonahwilliams @zanderso @googlebot @fluttergithubbot