Add CatmullRomCurve and CatmullRomSpline #47547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
framework
gspencergoog
force-pushed
the
checkbox_density
branch
from
4289ee9
to
b33cd01
Compare
goderbauer
reviewed
Jan 6, 2020
| } | ||
|
|
||
| @override | ||
| String toString() => '$runtimeType'; |
There was a problem hiding this comment.
runtimeType.toString is very slow.
There was a problem hiding this comment.
Yeah, but I'm not sure what else I would want to print here, and overriding it in each class to a string literal is error prone. It's generally only ever used in debug mode.
Isn't it just as slow to not override toString and have it print "Instance of MyType"?
gspencergoog
force-pushed
the
checkbox_density
branch
3 times, most recently
from
8ff4b86
to
9d9b573
Compare
goderbauer
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
LGTM, but maybe @HansMuller could also take a look since he seems to be more of a domain expert :)
gspencergoog
force-pushed
the
checkbox_density
branch
2 times, most recently
from
ec35d06
to
298d78d
Compare
gspencergoog
force-pushed
the
checkbox_density
branch
from
298d78d
to
8e0ea4b
Compare
gspencergoog
commented
Jan 8, 2020
bkonyi
pushed a commit
that referenced
this pull request
Jan 9, 2020
This adds CatmullRomCurve animation curve, and a CatmullRomSpline, which is what it uses to do interpolation. This allows us to create animation curves which can smoothly interpolate the values given to the curve. Since I've introduced a 2D spline curve, I also created a Curve2D base class for such parametric curves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
CatmullRomCurveanimation curve, and aCatmullRomSpline, which is what it uses to do interpolation.This allows us to create animation curves which can smoothly interpolate the values given to the curve.
Here's an example program that uses these curves, and lets you edit them to see their properties. (this is not a permanent location for this program, and eventually the goal is for it to be available in the API docs).
Since I've introduced a 2D spline curve, I also created a
Curve2Dbase class for such parametric curves.Tests
Breaking Change