Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consume font subsetting tools when caching artifacts.
This adds roughtly 2.5 mb of download, and about 6mb of additional cache overhead (font-subset executable is just over half a meg, const_finder snapshot is about 5.5 megs).
This also prints out a more friendly name for repeated tool artifacts, e.g. instead of repeatedly printing out
darwin-x64 tools
, it will print things likedarwin-x64/font-subset
(unless it's for theartifacts.zip
archive, in which case it will print the old string).Related Issues
#43642
#43644
Tests
I added the following tests:
Test that the new artifact does the expected things on various platforms: provide right paths on Windows/Mac/Linux, throw on other OS.
Test for friendly string logging.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.