Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download font-subset #49234

Merged
merged 2 commits into from Jan 22, 2020
Merged

download font-subset #49234

merged 2 commits into from Jan 22, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 21, 2020

Description

consume font subsetting tools when caching artifacts.

This adds roughtly 2.5 mb of download, and about 6mb of additional cache overhead (font-subset executable is just over half a meg, const_finder snapshot is about 5.5 megs).

This also prints out a more friendly name for repeated tool artifacts, e.g. instead of repeatedly printing out darwin-x64 tools, it will print things like darwin-x64/font-subset (unless it's for the artifacts.zip archive, in which case it will print the old string).

Related Issues

#43642
#43644

Tests

I added the following tests:

Test that the new artifact does the expected things on various platforms: provide right paths on Windows/Mac/Linux, throw on other OS.

Test for friendly string logging.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 21, 2020
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants