[flutter_tools] Generate correct entrypoint module name #49486
Conversation
fluttergithubbot
added
the
tool
| @@ -347,17 +341,20 @@ class WebDevFS implements DevFS { | |||
| 'web', | |||
| 'dart_stack_trace_mapper.js', | |||
| )); | |||
| final String entrypoint = PackageUriMapper(mainPath, '.packages', null, null) | |||
There was a problem hiding this comment.
Is this always a path under lib? What does PackageUriMapper do for files not under lib?
There was a problem hiding this comment.
If it's not under lib, it returns null - so I'm falling back to mainPath. That ... kinda works, what does the frontend_server produce in this case?
There was a problem hiding this comment.
Frontend_server will fall back to either the multi-root or absolute file uri (multi-root takes precedence).
The problem is down below we do /packages/$entrypoint.lib.js which won't work with the absolute or multi root uris (you probably just want $entrypoint.lib.js in that case?).
There was a problem hiding this comment.
Ahh yeah, I'd need to check for the whole thing being null. I'll update with some tests
jonahwilliams
moved this from Awaiting triage
to Engineer reviewed
in Tools - web review
Description
Ensure that the bootstrap module is requested as
packages/package-name/pathinstead of an absolute file path. Removes windows file-path workarounds from module mapping.