Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating snippets documentation README.md #50483

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

gspencergoog
Copy link
Contributor

Description

Updates the README file for snippets.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Feb 10, 2020
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a couple of nits.

I think the README files should also adhere to the 80 char minimum per line rule, since this helps with reading the docs when viewing them in an IDE.


Note that generating the sample output will not allow you to run your code in DartPad, because DartPad pulls the code it runs from the appropriate docs server (master or stable).

Copy your code and paste it into a regular DartPad instance to test if it runs in DartPad. You can get the code that will be produced by the interpolation of your code into a template by running the sample analysis locally (see the next section), and pasting the output file into a dartpad at https://dartpad.dartlang.org.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a little confusing to read "get the code that will be produced by the interpolation of your code into a template", so I tried to simplify it a little:

Suggested change
Copy your code and paste it into a regular DartPad instance to test if it runs in DartPad. You can get the code that will be produced by the interpolation of your code into a template by running the sample analysis locally (see the next section), and pasting the output file into a dartpad at https://dartpad.dartlang.org.
Copy the generated code and paste it into a regular DartPad instance to test if it runs in DartPad. To get the code that will be produced by your documentation changes, run sample analysis locally (see the next section) and paste the output into a DartPad at https://dartpad.dartlang.org.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's better.

@shihaohong
Copy link
Contributor

Also, the analyzer seems to be failing on trailing whitespaces, so that has to be fixed as well

@gspencergoog
Copy link
Contributor Author

I reflowed all the paragraphs, and formatted the lists to be more consistent in a "text" view, and removed the trailing whitespace.

@gspencergoog gspencergoog merged commit c6e45ff into flutter:master Feb 11, 2020
@gspencergoog gspencergoog deleted the dartpad_snippets branch February 11, 2020 17:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants