-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating snippets documentation README.md #50483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than a couple of nits.
I think the README files should also adhere to the 80 char minimum per line rule, since this helps with reading the docs when viewing them in an IDE.
dev/snippets/README.md
Outdated
|
||
Note that generating the sample output will not allow you to run your code in DartPad, because DartPad pulls the code it runs from the appropriate docs server (master or stable). | ||
|
||
Copy your code and paste it into a regular DartPad instance to test if it runs in DartPad. You can get the code that will be produced by the interpolation of your code into a template by running the sample analysis locally (see the next section), and pasting the output file into a dartpad at https://dartpad.dartlang.org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a little confusing to read "get the code that will be produced by the interpolation of your code into a template", so I tried to simplify it a little:
Copy your code and paste it into a regular DartPad instance to test if it runs in DartPad. You can get the code that will be produced by the interpolation of your code into a template by running the sample analysis locally (see the next section), and pasting the output file into a dartpad at https://dartpad.dartlang.org. | |
Copy the generated code and paste it into a regular DartPad instance to test if it runs in DartPad. To get the code that will be produced by your documentation changes, run sample analysis locally (see the next section) and paste the output into a DartPad at https://dartpad.dartlang.org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's better.
Also, the analyzer seems to be failing on trailing whitespaces, so that has to be fixed as well |
f30e64f
to
d64923f
Compare
I reflowed all the paragraphs, and formatted the lists to be more consistent in a "text" view, and removed the trailing whitespace. |
Description
Updates the README file for snippets.