Bumping tool_coverage-linux to 24G of memory to avoid OOM kills #50700
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: also investigating here: https://github.com/flutter/flutter/pull/50698/checks?check_run_id=442911140 Tentatively guessing it was the engine roll, though I'm not sure why it passed once |
|
OK, this wasn't sufficient. Something else must be wrong. I'll take a look again tomorrow. |
|
The reverted engine roll PR passed coverage on presubmit, though I'm not sure if that is a different environment than post submit. |
|
@jonahwilliams I say we try committing that revert and see what happens. |
|
LGTM for the TBR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I'm just going to double the original 12G to 24G and see if that's enough. It has been making more progress with more memory, so it's not an infinite loop (probably), but still is getting OOM killed.
Something has clearly changed, but looking at the commits, I can't see it: the OOM kills started on a PR that was an error message change.
TBR= @Hixie