Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll engine 0e8ed2715a35..e0ebaea59071 (31 commits) (#50671)" #50736

Merged
merged 1 commit into from Feb 13, 2020

Conversation

gspencergoog
Copy link
Contributor

This reverts commit 8b08120 to see if it is the cause of the coverage test OOM kills.

TBR= @jonahwilliams

This reverts commit 8b08120 to see if it is the cause of the coverage OOM kills.
@fluttergithubbot fluttergithubbot added the engine flutter/engine repository. See also e: labels. label Feb 13, 2020
@gspencergoog gspencergoog merged commit 0634832 into flutter:master Feb 13, 2020
@gspencergoog gspencergoog deleted the revert_engine_roll branch February 13, 2020 17:09
@yjbanov
Copy link
Contributor

yjbanov commented Feb 13, 2020

Possible fix for #50737

@dnfield
Copy link
Contributor

dnfield commented Feb 13, 2020

Here are the dart commits from that roll:

 dnfield@dnfield ~/src/flutter/engine/src/third_party/dart git log --oneline 5244d99a5d4e..e4c39721c473

e4c39721c4 [dart2js] Delete dart:mirrors patch file
855309a1dd [dartdevc] Delete patch files for mirrors library
40eaf81834 [vm/concurrency] Remove redundant isolates list, ensure shutdown procedure waits until the isolates actually got deleted
61b2d6a9a7 [nnbd/corelib] Restore null check in DateTime._withValue constructor
c3f75f0ca9 [cfe] Fix crashes due to wrong URIs in error reporting
2145850d40 [cfe] Check bounds for mutual subtyping in generic method overrides
76b18c455e Make DoubleLinkedQueue.firstEntry/lastEntry nullable again.
30151a6541 wait for SDK suggestions
f352f9e5e2 Revert "Reland "fix hanging of write on Windows""
5fc031ebc1 [VM/Libraries] Turn on NNBD versions of dart:io and dart:_http libraries
905a154f59 Remove import of dart:mirrors from dart:html
abf7d1fc08 Issue 40572. Pass Packages to AnalysisDriver.
e7ee11a95b Fix input and output for conversions
aae3d0817f Reland "[ DartFuzz ] Prevent generated programs from explicitly throwing OutOfMemoryError"
5457012b81 driver test suggestion support
085c4b49a4 Issue 40482. Fix for Function?.call() reporting unchecked nullable.
20e20a0c66 [vm/nnbd] Fix lazy _InvocationMirror._type initialization
7be0667fc3 Issue 40398. Fix for checking type arguments in legacy libraries.
2edd3d5e4a Issue 40414. Test for invalid override checked even via legacy library.
c969c51aa4 [nnbd preview] update item presentation; show line numbers
1256b50a15 Fix issues found compiling with clang on Windows
5e74472449 Handle optionals in DOM scripts for NNBD
af4a3112c4 Reland "fix hanging of write on Windows"
85c197a848 Optional parameters of abstract methods may omit default values.
c7b65f65b9 Simplify analyzer pub constraints
96794c5aae Fix windows bot failure due to missing path conversion.
0fde59b21d [vm] Further mirrors and test fixes.
63b5d2b053 Migration: Allow null info when introducing `as`.
a017944035 Migration: fix hard crash in trial_migration when migrating package:async.
41cef5f82f [vm] Never enter a safepoint under a regular MutexLocker.
4f35a405ff [VM/nnbd] Update runtime and code generation of 'is instance of' for NNBD.
8871d3bc1c Bump the version numbers in the test package config to "2.7".
cd53f4ffe1 Add null-safety to html_common
10f2b8fc76 migrate path specification to driver clients
9af1ffc558 Don't generate getters/setters for read only promises
eddfbb1776 [dartdevc] Wrapping function types with nullability wrappers.
0bd76c7d37 Issue 40546. Ensure that getSourceKind() works for changed files.
661fd081fb [lib] Re-add a null check in Double.toStringAsPrecision
b86c6e0ce9 [lib] Fix some NNBD lib tests
721035cd3d [vm/nnbd] Fix RangeError in NoSuchMethodError._toStringDeprecated
82b73697d7 [dartdevc] Implementing generic function type object equality.
4152aa5be2 [dartdevc] Adding support for required named parameters weak mode semantics.
3d97d22fe5 completion driver suggestions
160614929a [vm/ffi] Fix sign extension for small int arguments on x64 Linux/MacOS
f338ed8638 [vm/concurrency] Ensure TFA doesn't eliminate static field, to ensure objects stay alive when asking for allocation stats
21758fe93c Create a package_config.json file for the generated multitests.
e01457d138 Reland "[vm/aot] Remove object wrapping of bare instructions for AOT snapshots."
293c5bec50 Revert "[VM/Libraries] Turn on NNBD versions of dart:io and dart:_http libraries"
27385faab5 [vm/ffi] NNBD: Change nullptr type argument to Never
9e1bbc1203 Ensuring that every feature spec in SDK is marked as background material
d0e779ff71 Improve some diagnostic documentation

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants