[flutter_tools] include LICENSE files as build dependencies #50945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
|
Note: this needs a corresponding change in google3 due to |
dnfield
approved these changes
Feb 18, 2020
| if (licenseText == null) { | ||
| packageNames = <String>[packageName]; | ||
| licenseText = rawLicense; | ||
| final File file = _fileSystem.file(package.resolve('../LICENSE')); |
There was a problem hiding this comment.
Not for this patch, but this seems like something we should delegate to pub.
|
Going to avoid landing this until I update other implementations |
jonahwilliams
moved this from Awaiting triage
to Engineer reviewed
in Tools - team support review
|
Upstream change has landed, this is safe to submit now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
have the AssetManifest track LICENSE files as input dependencies using a refactored LicenseCollector. Surface these dependencies as depfile inputs to ensure the bundle is rebuilt if a LICENSE file changes.
Adds note about current bug in the license processing, and includes tests for some of the current license behavior.
Fixes #27720