Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder #51150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a few tests that depend on the page transition theme's default value for
TargetPlatform.android
, which blocks updating the default activity transitions. This PR sets the page transition for particular tests that rely on theFadeUpwardsTransitionBuilder
's implementation details, while fixing tests that were incorrectly looking for aFadeTransition
widget or searching theentire widget tree when it is unnecessary.
This isn't a breaking change because no actual implementation code has been changed, even though the tests were modified.
Related Issues
Fixes #51145
Tests
PageTransitionsTheme
values where appropriate (every other test)Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.