Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder #51150

Merged

Conversation

shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Feb 21, 2020

Description

There are a few tests that depend on the page transition theme's default value for TargetPlatform.android, which blocks updating the default activity transitions. This PR sets the page transition for particular tests that rely on the FadeUpwardsTransitionBuilder's implementation details, while fixing tests that were incorrectly looking for a FadeTransition widget or searching the
entire widget tree when it is unnecessary.

This isn't a breaking change because no actual implementation code has been changed, even though the tests were modified.

Related Issues

Fixes #51145

Tests

  1. This PR fixes broken tests that incorrectly assume the presence of FadeTransition/Opacity widgets (BottomNavigationBar tests)
  2. This PR removes reliance on default PageTransitionsTheme values where appropriate (every other test)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 21, 2020
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, solid improvement!

@fluttergithubbot fluttergithubbot merged commit 6d4121c into flutter:master Feb 23, 2020
@shihaohong shihaohong deleted the decouple-default-page-transition branch February 23, 2020 01:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Material library tests from the default Material page transition
4 participants