Update covariant_templates_test after changes to TypeError. #51330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeError no longer implements AssertionError after dart-lang/sdk#40317.
fluttergithubbot
added
the
framework
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 24, 2020
The corresponding Flutter change is made in flutter/flutter#51330. Change-Id: Ib3f233cd4153c04b22ba10e30eb532186fc9fb97 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136961 Reviewed-by: Clement Skau <cskau@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
|
You can relax this condition, i.e. make current TOT pass and when engine rolls. Once the auto rollers have rolled everything we can make the check stricter again with new semantics. |
mkustermann
approved these changes
Feb 24, 2020
|
The builders seem to be backed up, and I've run this through the autoroller locally, so I'm landing it preemptively to get the roll going again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError no longer implements AssertionError after dart-lang/sdk#40317.