Added ability to change dropdown colour manually #52982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
|
For test, you expanded dropdown like this example From there, you can grab the CustomPainter that paints the retangle by using find.ancestor. Once you have the CustomPainter, you can use expect(CustomPainter, paint.rrect(...)). See this example |
chunhtai
reviewed
Mar 30, 2020
| @@ -1030,6 +1039,10 @@ class DropdownButton<T> extends StatefulWidget { | |||
| /// {@macro flutter.widgets.Focus.autofocus} | |||
| final bool autofocus; | |||
|
|
|||
| /// The color of the dropdown's background color. If not provided the theme's | |||
There was a problem hiding this comment.
can you break the If into a new line?
/// The color of the dropdown's background color.
///
/// If it is null, the theme's canvas color will be used instead.
| @@ -800,6 +808,7 @@ class DropdownButton<T> extends StatefulWidget { | |||
| this.focusColor, | |||
| this.focusNode, | |||
| this.autofocus = false, | |||
| this.dropdownColor, | |||
There was a problem hiding this comment.
Somewhere in the DropdownButton doc string should mention how and when to use dropdownColor
|
OK, I made those changes. |
chunhtai
approved these changes
Apr 1, 2020
| @@ -174,6 +176,41 @@ void verifyPaintedShadow(Finder customPaint, int elevation) { | |||
| ); | |||
| } | |||
|
|
|||
| Future<void> checkDropdownColor(WidgetTester tester, {Color color}) async { | |||
| @@ -789,6 +797,10 @@ class DropdownButton<T> extends StatefulWidget { | |||
| /// The [elevation] and [iconSize] arguments must not be null (they both have | |||
| /// defaults, so do not need to be specified). The boolean [isDense] and | |||
| /// [isExpanded] arguments must not be null. | |||
| /// | |||
| /// The [dropdownColor] argument specifies the background color of the | |||
| /// dropdown when it is open. If it is null the current theme's | |||
There was a problem hiding this comment.
If it is null, the current theme's...
| @@ -1049,6 +1062,11 @@ class DropdownButton<T> extends StatefulWidget { | |||
| /// {@macro flutter.widgets.Focus.autofocus} | |||
| final bool autofocus; | |||
|
|
|||
| /// The color of the dropdown's background color. | |||
| /// | |||
| /// If not provided the theme's [ThemeData.canvasColor] will be used instead. | |||
There was a problem hiding this comment.
If it is not provided, the theme's...
| @@ -1049,6 +1062,11 @@ class DropdownButton<T> extends StatefulWidget { | |||
| /// {@macro flutter.widgets.Focus.autofocus} | |||
| final bool autofocus; | |||
|
|
|||
| /// The color of the dropdown's background color. | |||
There was a problem hiding this comment.
The background color of the dropdown.
| const String text = 'foo'; | ||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| home: Material( |
There was a problem hiding this comment.
MaterialApp can be replaced by TestApp and Material can be replaced by Scaffold, but it appears to be required.
|
|
||
| expect( | ||
| find.ancestor( | ||
| of: find.text(text).last, |
| await tester.pump(); | ||
|
|
||
| expect( | ||
| find.ancestor( |
|
It also seems the branch is behind, can you rebase off the master? |
|
OK, done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before there was no way to manually set the colour of a dropdown (when it is open) and is always set to the theme's
canvasColor. This is a bit weird as most other widgets have an option to override their default colour. This PR adds that ability using the newdropdownColorparameter.Related Issues
Tests
No tests as I could not find a way to easily start a dropdown as expanded. Did add a hook in /packages/flutter/test/material/dropdown_test.dart to test the functionality though.'DropdownButton uses default color when expanded' and 'DropdownButton hint displays properly when selectedItemBuilder is defined' in dropdown_test.dart.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].