Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IMobileDevice from globals, hoist to XCDevice constructor #53144

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Remove IMobileDevice from globals, hoist to XCDevice constructor #53144

merged 2 commits into from
Mar 24, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 24, 2020 •
edited
Loading

Description

Remove IMobileDevice from globals, hoist to XCDevice constructor
ios_device_logger_test.dart to testWithoutContext

Related Issues

#47161

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 24, 2020
@jmagman jmagman self-assigned this Mar 24, 2020
@jmagman jmagman changed the title Convert ios_device_logger_test.dart to testWithoutContext IMobileDevice from globals, hoist to XCDevice constructor Mar 24, 2020
@jmagman jmagman changed the title IMobileDevice from globals, hoist to XCDevice constructor Remove IMobileDevice from globals, hoist to XCDevice constructor Mar 24, 2020
christopherfujino
christopherfujino approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 0b321e6 into flutter:master Mar 24, 2020
@jmagman jmagman deleted the imobiledevice branch March 24, 2020 18:22
@jmagman jmagman mentioned this pull request Mar 25, 2020
Merged
10 tasks
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @christopherfujino @googlebot