[flutter_tools] Lazily inject logger into web devices #55961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
DanTup
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
LGTM, events coming through with this. Thanks!
[4:56:09 PM] [FlutterRun] [Info] [Flutter App] <== [{"event":"app.progress","params":{"appId":"97e3792b-1fe1-458b-b562-4892b32ef662","id":"0","progressId":null,"finished":true}}]
[4:56:09 PM] [FlutterRun] [Info] [Flutter App] <== Waiting for connection from Dart debug extension at http://localhost:49408
[4:56:09 PM] [FlutterRun] [Info] [Flutter App] <== [{"event":"app.webLaunchUrl","params":{"url":"http://localhost:49408","launched":false}}]
|
Cirrus is less happy though 🙃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Constructing the WebDevices with the global logger too early will lead to them grabbing the StdoutLogger when running in daemon mode. This prevents IDEs from seeing the correct debug message.
Dart-Code/Dart-Code#2407 (comment)