Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[version] update all versions #56141

Merged
merged 3 commits into from May 1, 2020
Merged

[version] update all versions #56141

merged 3 commits into from May 1, 2020

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented May 1, 2020 •
edited

Description

Fixes #54290

Piinks
Piinks approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Member Author

Submitting on red since the devicelab failure is a 500 when updating benchmarks

@jonahwilliams jonahwilliams merged commit ac2dfcf into flutter:master May 1, 2020
@jonahwilliams jonahwilliams deleted the roll_versions_123291812398 branch May 1, 2020 22:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web]: Syncing files to device Chrome - Stuck
3 participants
@jonahwilliams @Piinks @googlebot