New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] reland remove flutter view cache #56387
[flutter_tools] reland remove flutter view cache #56387
Conversation
This reverts commit 8574cc7.
Future<void> exitApps({ | ||
@visibleForTesting Duration timeoutDelay = const Duration(seconds: 10), | ||
}) async { | ||
if (!device.supportsFlutterExit) { | ||
if (!device.supportsFlutterExit || vmService == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix
@@ -811,10 +818,20 @@ void main() { | |||
expect(fakeVmServiceHost.hasRemainingExpectations, false); | |||
})); | |||
|
|||
test('FlutterDevice can exit from a release mode isolate with no VmService', () => testbed.run(() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test
NNBD when! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #56194
Remove caching of FlutterView and poll forever if the list of flutter views is empty.
Added test for missing release mode logic.