Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Update test skip description. #57240

Merged
merged 2 commits into from May 18, 2020
Merged

[web] Update test skip description. #57240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c9b35
Resolve skip
ferhatb May 14, 2020
3f107af
Merge remote-tracking branch 'upstream/master' into chunktest
ferhatb May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutter/test/painting/image_provider_network_image_test.dart
View file
Open in desktop
Expand Up @@ -183,7 +183,7 @@ void main() {
expect(events[i].cumulativeBytesLoaded, math.min((i + 1) * chunkSize, kTransparentImage.length));
expect(events[i].expectedTotalBytes, kTransparentImage.length);
}
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/56317
}, skip: isBrowser); // Browser loads images through <img> not Http.

test('NetworkImage is evicted from cache on SocketException', () async {
final _MockHttpClient mockHttpClient = _MockHttpClient();
Expand Down