[flutter_tools] reland: remove globals from android device/testing #57614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
tool
jonahwilliams
commented
May 19, 2020
| Logger logger, | ||
| Platform platform, | ||
| ProcessManager processManager, | ||
| @required TimeoutConfiguration timeoutConfiguration, |
There was a problem hiding this comment.
I forgot to make this required, and it was null - causing the failure.
There was a problem hiding this comment.
How did that pass the Cirrus tests the first time?
There was a problem hiding this comment.
I guess no integration test hit android device discovery for real.
There was a problem hiding this comment.
FWIW I did test the change initially, but not after I updated device discovery 🤦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-land refactor of android_devices.dart and testing. Fixed because I forgot to provide a timeout configuration since it is not on globals.